Hook up Caching

podpac/core/algorithm/algorithm.py

@@ -21,6 +21,7 @@
 from podpac.core.units import UnitsDataArray
 from podpac.core.node import Node
 from podpac.core.node import COMMON_NODE_DOC
+from podpac.core.node import node_eval
 from podpac.core.utils import common_doc
 
 COMMON_DOC = COMMON_NODE_DOC.copy()
@@ -51,6 +52,7 @@ def _inputs(self):
         }
 
     @common_doc(COMMON_DOC)
+    @node_eval
     def eval(self, coordinates, output=None):
         """Evalutes this nodes using the supplied coordinates. 
 
@@ -79,16 +81,15 @@ def eval(self, coordinates, output=None):
         result = self.algorithm(inputs)
         if isinstance(result, np.ndarray):
             if output is None:
-                output = self.create_output_array(output_coordinates)
-            output.data[:] = result
+                output = self.create_output_array(output_coordinates, data=result)
+            else:
+                output.data[:] = result
         else:
             if output is None:
-                output_coordinates = Coordinates.from_xarray(result.coords)
-                output = self.create_output_array(output_coordinates)
-            output[:] = result
-            output = output.transpose(*[dim for dim in coordinates.dims if dim in result.dims])
+                output = result
+            else:
+                output[:] = result
 
-        self._output = output
         return output
 
     def find_coordinates(self):

podpac/core/algorithm/coord_select.py

@@ -42,21 +42,6 @@ class ModifyCoordinates(Algorithm):
     @tl.default('coordinates_source')
     def _default_coordinates_source(self):
         return self.source
-
-    def algorithm(self, inputs):
-        """Passthrough of the source data
-
-        Arguments
-        ----------
-        inputs : dict
-            Evaluated output of the input nodes. The keys are the attribute names.
-
-        Returns
-        -------
-        UnitDataArray
-            Source evaluated at the expanded coordinates
-        """
-        return inputs['source']
 
     @common_doc(COMMON_DOC)
     def eval(self, coordinates, output=None):
@@ -79,18 +64,23 @@ def eval(self, coordinates, output=None):
         """
 
         self._requested_coordinates = coordinates
-
-        modified_coordinates = Coordinates(
+        self.outputs = {}
+        self._modified_coordinates = Coordinates(
             [self.get_modified_coordinates1d(coordinates, dim) for dim in coordinates.dims])
-        for dim in modified_coordinates.udims:
-            if modified_coordinates[dim].size == 0:
+
+        for dim in self._modified_coordinates.udims:
+            if self._modified_coordinates[dim].size == 0:
                 raise ValueError("Modified coordinates do not intersect with source data (dim '%s')" % dim)
-        output = super(ModifyCoordinates, self).eval(modified_coordinates, output=output)
 
-        # debugging
-        self._modified_coordinates = modified_coordinates
-        self._output = output
+        self.outputs['source'] = self.source.eval(self._modified_coordinates, output=output, method=method)
+
+        if output is None:
+            output = self.outputs['source']
+        else:
+            output[:] = self.outputs['source']
 
+        if self.debug:
+            self._output = output
         return output
 
 class ExpandCoordinates(ModifyCoordinates):
@@ -207,4 +197,4 @@ def get_modified_coordinates1d(self, coords, dim):
         else:
             raise ValueError("Invalid selection attrs for '%s'" % dim)
 
-        return coords1d
+        return coords1d

podpac/core/algorithm/signal.py

@@ -21,7 +21,7 @@
 from podpac.core.node import Node
 from podpac.core.algorithm.algorithm import Algorithm
 from podpac.core.utils import common_doc
-from podpac.core.node import COMMON_NODE_DOC
+from podpac.core.node import COMMON_NODE_DOC, node_eval
 
 COMMON_DOC = COMMON_NODE_DOC.copy()
 COMMON_DOC['full_kernel'] = '''Kernel that contains all the dimensions of the input source, in the correct order.
@@ -77,6 +77,7 @@ class Convolution(Algorithm):
     _full_kernel = tl.Instance(np.ndarray)
 
     @common_doc(COMMON_DOC)
+    @node_eval
     def eval(self, coordinates, output=None):
         """Evaluates this nodes using the supplied coordinates.
 
@@ -91,20 +92,18 @@ def eval(self, coordinates, output=None):
         -------
         {eval_return}
         """
-        self._requested_coordinates = coordinates
-
         # This should be aligned with coordinates' dimension order
         # The size of this kernel is used to figure out the expanded size
         self._full_kernel = self.get_full_kernel(coordinates)
-        shape = self._full_kernel.shape
 
-        if len(shape) != len(coordinates.shape):
-            raise ValueError("Kernel shape does not match source data shape")
+        if len(self._full_kernel.shape) != len(coordinates.shape):
+            raise ValueError("shape mismatch, kernel does not match source data (%s != %s)" % (
+                self._full_kernel.shape, coordinates.shape))
 
         # expand the coordinates
         exp_coords = []
         exp_slice = []
-        for dim, s in zip(coordinates.dims, shape):
+        for dim, s in zip(coordinates.dims, self._full_kernel.shape):
             coord = coordinates[dim]
             if s == 1 or not isinstance(coord, UniformCoordinates1d):
                 exp_coords.append(coord)
@@ -121,8 +120,19 @@ def eval(self, coordinates, output=None):
                 coord.step,
                 **coord.properties))
             exp_slice.append(slice(-s_start, -s_end))
-        exp_coords = Coordinates(exp_coords)
         exp_slice = tuple(exp_slice)
+        self._expanded_coordinates = Coordinates(exp_coords)
+
+        # evaluate source using expanded coordinates, convolve, and then slice out original coordinates
+        self.outputs['source'] = self.source.eval(self._expanded_coordinates, method=method)
+
+        if np.isnan(np.max(self.outputs['source'])):
+            method = 'direct'
+        else:
+            method = 'auto'
+
+        result = scipy.signal.convolve(self.outputs['source'], self._full_kernel, mode='same', method=method)
+        result = result[exp_slice]
 
         # evaluate using expanded coordinates and then reduce down to originally requested coordinates
         out = super(Convolution, self).eval(exp_coords)
@@ -132,10 +142,6 @@ def eval(self, coordinates, output=None):
         else:
             output[:] = result
 
-        # debugging
-        self._expanded_coordinates = exp_coords
-        self._output = output
-
         return output
 
     @tl.default('kernel')
@@ -163,26 +169,6 @@ def get_full_kernel(self, coordinates):
         """
         return self.kernel
 
-    def algorithm(self, inputs):
-        """Computes the convolution of the source and the kernel
-
-        Arguments
-        ----------
-        inputs : dict
-            evaluated outputs of the input nodes. The keys are the attribute names.
-
-        Returns
-        -------
-        np.ndarray
-            Resultant array. 
-        """
-        if np.isnan(np.max(inputs['source'])):
-            method = 'direct'
-        else:
-            method = 'auto'
-        res = scipy.signal.convolve(inputs['source'], self._full_kernel, mode='same', method=method)
-        return res
-
 
 class TimeConvolution(Convolution):
     """Compute a temporal convolution over a source node.

podpac/core/algorithm/stats.py

@@ -18,7 +18,7 @@
 from podpac.core.node import Node
 from podpac.core.algorithm.algorithm import Algorithm
 from podpac.core.utils import common_doc
-from podpac.core.node import COMMON_NODE_DOC
+from podpac.core.node import COMMON_NODE_DOC, node_eval
 
 COMMON_DOC = COMMON_NODE_DOC.copy()
 
@@ -162,6 +162,7 @@ def iteroutputs(self, coordinates):
             yield self.source.eval(chunk)
 
     @common_doc(COMMON_DOC)
+    @node_eval
     def eval(self, coordinates, output=None):
         """Evaluates this nodes using the supplied coordinates. 
 
@@ -204,7 +205,6 @@ def eval(self, coordinates, output=None):
         else:
             output[:] = result
 
-        self._output = output
         return output
 
     def reduce(self, x):
@@ -907,6 +907,7 @@ def _get_source_coordinates(self, requested_coordinates):
         return coords
 
     @common_doc(COMMON_DOC)
+    @node_eval
     def eval(self, coordinates, output=None):
         """Evaluates this nodes using the supplied coordinates. 
 
@@ -926,7 +927,7 @@ def eval(self, coordinates, output=None):
         ValueError
             If source it not time-depended (required by this node).
         """
-        self._requested_coordinates = coordinates
+
         self._source_coordinates = self._get_source_coordinates(coordinates)
 
         if output is None:
@@ -950,7 +951,6 @@ def eval(self, coordinates, output=None):
         out = out.sel(**{self.groupby:E}).rename({self.groupby: 'time'})
         output[:] = out.transpose(*output.dims).data
 
-        self._output = output
         return output
 
     def base_ref(self):

podpac/core/compositor.py

@@ -13,6 +13,8 @@
 from podpac.core.coordinates import Coordinates, merge_dims
 from podpac.core.node import Node
 from podpac.core.utils import common_doc
+from podpac.core.node import COMMON_NODE_DOC 
+from podpac.core.node import node_eval 
 from podpac.core.data.datasource import COMMON_DATA_DOC
 from podpac.core.data.interpolate import interpolation_trait
 from podpac.core.utils import trait_is_defined
@@ -200,6 +202,7 @@ def f(src):
                 yield output
                 output[:] = np.nan
 
+    @node_eval
     @common_doc(COMMON_COMPOSITOR_DOC)
     def eval(self, coordinates, output=None):
         """Evaluates this nodes using the supplied coordinates. 
@@ -220,8 +223,6 @@ def eval(self, coordinates, output=None):
 
         outputs = self.iteroutputs(coordinates)
         output = self.composite(outputs, output)
-
-        self._output = output
         return output
 
     def find_coordinates(self):

podpac/core/data/datasource.py

@@ -19,6 +19,7 @@
 from podpac.core.node import Node, NodeException
 from podpac.core.utils import common_doc, trait_is_defined
 from podpac.core.node import COMMON_NODE_DOC
+from podpac.core.node import node_eval
 from podpac.core.data.interpolate import Interpolation, interpolation_trait
 
 DATA_DOC = {
@@ -166,7 +167,7 @@ class DataSource(Node):
     # privates
     _interpolation = tl.Instance(Interpolation)
 
-    _evaluated_coordinates = tl.Instance(Coordinates, allow_none=True)
+    _original_requested_coordinates = tl.Instance(Coordinates, allow_none=True)
     _requested_source_coordinates = tl.Instance(Coordinates)
     _requested_source_coordinates_index = tl.List()
     _requested_source_data = tl.Instance(UnitsDataArray)
@@ -272,6 +273,10 @@ def eval(self, coordinates, output=None):
         if self.coordinate_index_type != 'numpy':
             warnings.warn('Coordinates index type {} is not yet supported.'.format(self.coordinate_index_type) +
                           '`coordinate_index_type` is set to `numpy`', UserWarning)
+
+        # store requested coordinates for debugging
+        if self.debug:
+            self._original_requested_coordinates = coordinates
 
         # check for missing dimensions
         for c in self.native_coordinates.values():
@@ -296,7 +301,10 @@ def eval(self, coordinates, output=None):
         # set input coordinates to evaluated coordinates
         # TODO move this if WCS can be updated to support
         self._evaluated_coordinates = coordinates
+        return self._eval(coordinates, output=output, method=None)
 
+    @node_eval
+    def _eval(self, coordinates, output=None):
         # intersect the native coordinates with requested coordinates
         # to get native coordinates within requested coordinates bounds
         # TODO: support coordinate_index_type parameter to define other index types
@@ -309,8 +317,6 @@ def eval(self, coordinates, output=None):
                 output = self.create_output_array(coordinates)
             else:
                 output[:] = np.nan
-
-            self._output = output
             return output
 
         # reset interpolation

podpac/core/data/types.py

@@ -804,14 +804,14 @@ def native_coordinates(self):
         data wrangling for us...
         """
 
-        # TODO update so that we don't rely on _evaluated_coordinates
-        if not self._evaluated_coordinates:
+        # TODO update so that we don't rely on _requested_coordinates if possible
+        if not self._requested_coordinates:
             return self.wcs_coordinates
 
         cs = []
         for dim in self.wcs_coordinates.dims:
-            if dim in self._evaluated_coordinates.dims:
-                c = self._evaluated_coordinates[dim]
+            if dim in self._requested_coordinates.dims:
+                c = self._requested_coordinates[dim]
                 if c.size == 1:
                     cs.append(ArrayCoordinates1d(c.coordinates[0], name=dim))
                 elif isinstance(c, UniformCoordinates1d):