Feature/geotiff export #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 156b0ac)
(cherry picked from commit 70dd8d4)
…with geotiff creation.
* Fixed some inconsistencies / bugs in the geotransform. I'm trying to move most of the heavy lifting to the Coordinates object * The GDAL transform's first line is for the X or Lon direction, the second line is for the Y or Lat direction, which means if the data is not organized so that rows corresponds to changes in lat, we need to rework some automatically computed geotransforms
* Coordinates now handles the `from_geotransform` work, and operates with both rot (untested) and uniform coordinates (tested)
* Rot coords will be tested once #363 is solved
* Extended Rasterio to handle multi-band data.
* Removed logic from get_native_coordinates and used Coordinates.from_geotransform instead
* In the units.to_geotiff function, converted back to an rasterio.affine geotransform due to deprecation warning... perhaps should do the affine geotransform everywhere.
… the time dimension for geotransforms.
…doesn't have geotransform implemented.
|
Okay. Tests are passing. Let me know if you have any comments @jmilloy, I'd like to merge today. |
Merged
jmilloy
requested changes
Feb 5, 2020
|
@jmilloy Looks like the tests are passing. Please merge if you're happy. Otherwise I'll merge it when I have a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds geotiff export support to podpac. This is in support of the WCS OGC endpoint.
Right now the rotated coordinates are probably not working, but with this update 90% of the WCS endpoint should work. That piece is untested.