Feature/uniform coords transform to uniform #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill do Uniform-> Uniform/Array, but not Dependent/Stacked -> Uniform/Array
* Stripped out a lot of repeated code * A dependent coordinate will now get transformed back into uniform coordinates if possible.
…stransform). Also adding "alt" to the simplification.
This was referenced Apr 19, 2020
|
I will review this afternoon. |
…tart and stop are the same and the step is 0. * raise an exception if the step is 0 * add a test for this case * fix the typo in the datasource tests
jmilloy
reviewed
Apr 20, 2020
jmilloy
reviewed
Apr 20, 2020
…ses allclose. Prefer allclose over explicit TOL check in dependent coordinates simplify.
Moves the error cases to the top of the file, and moves the inline function out. I find this a lot easier to read.
|
Can you help me find two crs that that transform spatially uniform -> dependent but that I can add vunits to? For example, |
jmilloy
reviewed
Apr 20, 2020
Use Coordinates1d simplify method instead of make_uniform helper. Use np.linspace directly instead of clinspace(...).coordinates. Use StackedCoordinates._transform instead of Coordinates(StackedCoordinates).transform
Includes improvement to StackedCoordinates._transform (use simplify) and associated test.
jmilloy
approved these changes
Apr 21, 2020
|
Pending tests this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplified any transformed coordinates to independent / array / uniform coordinates.
This only one missing is stacked array to stacked uniform (a pretty rare case).
@jmilloy please have a quick look in case I missed something. It's a little convoluted so I want to document that code a little better, but beyond that I think it's pretty good.