ENH: Enabling NN interpolation for nD stacked coordinates. #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmilloy I'm merging this because I need it soon. I marked you on this one because I was really surprised that this wasn't working. I'm not sure when this broke because it used to work with dependent coordinates. I think it broke sometime between the dependent coordinates refactor and then interpolation refactor. |
|
Are you still wanting me to look through it, or are you happy with it? |
|
You don't have to, I just want to talk to you about it at some point. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to interpolate from the MODIS coordinates to EPSG:4326. This is a non-linear transform so the MODIS coordinates end up being 2D stacked coordinates (formerly dependent coordinates) that we need to interpolate.
This fixes the selector so that it can handle this case. It also fixes the nearest neighbor interpolator.
In the code I'm marking the 2D stacked coordinates by putting the indexes in a tuple, so that's what I'm checking for in the code. This is a bit of a hack.