Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter docs for convention-breakers #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheDeveloper
Copy link

Thought this could be useful when using Step with libraries that don't observe the callback(err,res) convention.

Wdyt?

@creationix
Copy link
Owner

Good idea, but using the inline self-calling function is terribly confusing.

@TheDeveloper
Copy link
Author

True - I've clarified it a bit. Untested but should work.

@creationix
Copy link
Owner

Better would be to simply convert the function to be node-style without involving step at all. I don't like using bind to insert step's "this" into the wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants