Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading multple threesixty sliders #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williscool
Copy link

by making sure the progress loader selectors dont collide.

just needed to make sure we find the element under the base selector.

also corrected the documentation comment on top of the function name

by making sure the progress loader selectors dont collide.

just needed to make sure we find the element under the base selector.

also corrected the documentation comment on top of the function name
@williscool
Copy link
Author

also found another fun bug

if you control the rotation with window.onscroll and you hit the gotoAndPlay function (by the scroll event triggering) before the slider has loaded all of the images... it will throw a bunch of exceptions in the hidePreviousFrame and showCurrentFrame buttons.

I think this has to do with base.getNormalizedCurrentFrame() being calculated with the wrong number of images and thrown off by what gotoAndPlay does to the internal representation of end frame.

Fix I did was to just put my window.onscroll function into the onReady call back.

And it all just worked.

Just thought others might like to know

  • Will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant