Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update location that CC license icons are served from #141

Closed
kgodey opened this issue Mar 18, 2020 · 2 comments · Fixed by #173
Closed

Update location that CC license icons are served from #141

kgodey opened this issue Mar 18, 2020 · 2 comments · Fixed by #173
Milestone

Comments

@kgodey
Copy link
Member

kgodey commented Mar 18, 2020

Description

CC license icons in the chooser need to be served from the same location as the icons on https://creativecommons.org/about/downloads (https://mirrors.creativecommons.org). We should use a query string parameter to indicate that traffic is coming from the chooser.

e.g. the CC icon could use the URL https://mirrors.creativecommons.org/presskit/icons/cc.svg?chooser-v1

@akmadian akmadian added this to the Someday milestone Apr 14, 2020
@obulat
Copy link
Contributor

obulat commented May 24, 2020

@kgodey , I started working on this issue, but I have a question regarding the link:
In the links that we have currently, the parameter in url is added with 'ref=', and in link you gave above doesn't have the 'ref='. Which one should we use?

@kgodey
Copy link
Member Author

kgodey commented May 26, 2020

We should use the "ref", thanks for spotting that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants