Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cc icons and location they are served from #173

Merged
merged 2 commits into from
May 29, 2020
Merged

Update cc icons and location they are served from #173

merged 2 commits into from
May 29, 2020

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 28, 2020

Fixes

Fixes #141 by @kgodey

Description

Updated the location from which icons that are embedded in html code are loaded from to https://mirrors.creativecommons.org. Also, I removed background circle from license icons so that they look better when the background is lighterGray.

Screenshots

With white background circle:

WhiteBackgroundIcons

Without white background circle:

IconsOnLighterGrayBackground

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The icons location for generated license html code is set to  https://mirrors.creativecommons.org/presskit/icons/<cc.svg>?ref=chooser-v1. Names of icons used in generated license richtext code and LicenseDetailsCard are updated to be the same as the names for html code ('cc-sa_icon.svg' -> 'sa.svg') for consistency.
@obulat obulat requested review from a team, brenoferreira and akmadian and removed request for a team May 28, 2020 14:43
@obulat obulat merged commit be72dce into master May 29, 2020
@obulat obulat deleted the icons branch May 29, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update location that CC license icons are served from
2 participants