-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests if AttributionDetailsStep component is mounted correctly #133
Tests if AttributionDetailsStep component is mounted correctly #133
Conversation
- Adds tests to test rendering of AttributionDetailsComponent @ different statuses - Modifies unit test to test condition status is current - Modifies snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Jackie, this is a good start! Jest coverage is showing lines 48, 57, 63, 69, and 75 as being uncovered, which means that it thinks there are tests that should be written for those lines, but there aren't. Please try adding tests for the uncovered lines
When writing tests for the computed props, please use the mocked VueX state to ensure the mutations are working properly :)
-modifies AttributionDetailsStep Rendering block by adding beforeEach and afterEach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for working on this!
module.exports = { | ||
'@tags': ['att'], | ||
'AttributionDetailsStep'(browser){ | ||
const knowLicenseSelector = '.b-radio' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a bit much, a lot of things being checked are static and always rendered since they're right there in the markdown, but I think it's ok for now
Fixes #112
Description
Other information
Checklist
Update index.md
).master
branch of the repository.visible errors.
Developer Certificate of Origin