Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests if AttributionDetailsStep component is mounted correctly #133

Merged
merged 6 commits into from
Mar 18, 2020
Merged

Tests if AttributionDetailsStep component is mounted correctly #133

merged 6 commits into from
Mar 18, 2020

Conversation

JackieBinya
Copy link
Contributor

Fixes #112

Description

  • This PR adds a unit test, to test whether the AttributionDetailsStep Component is rendered correctly

Other information

  • This is my first PR, I am trying to make sure that I followed best practices and the test I wrote so far meets expectations.
  • I would love to add more tests that test if that the state is correctly updated if a user fills in the input fields

Checklist

  • ✅ My pull request has a descriptive title (not a vague title like Update index.md).
  • ✅ My pull request targets the master branch of the repository.
  • ✅ My commit messages follow best practices.
  • ✅I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • ✅ I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@JackieBinya JackieBinya requested review from a team March 13, 2020 00:45
- Adds tests to test rendering of AttributionDetailsComponent @ different statuses
- Modifies unit test to test condition status is current
- Modifies snapshot
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jackie, this is a good start! Jest coverage is showing lines 48, 57, 63, 69, and 75 as being uncovered, which means that it thinks there are tests that should be written for those lines, but there aren't. Please try adding tests for the uncovered lines

When writing tests for the computed props, please use the mocked VueX state to ensure the mutations are working properly :)

-modifies AttributionDetailsStep Rendering block by adding beforeEach and afterEach
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for working on this!

module.exports = {
'@tags': ['att'],
'AttributionDetailsStep'(browser){
const knowLicenseSelector = '.b-radio'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a bit much, a lot of things being checked are static and always rendered since they're right there in the markdown, but I think it's ok for now

@akmadian akmadian merged commit cd1d995 into creativecommons:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit and e2e tests for AttributionDetailsStep component
2 participants