-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modals #175
Merged
Fix modals #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2e tests were failing due to outdated Chromedriver.
obulat
requested review from
a team,
brenoferreira and
akmadian
and removed request for
a team
May 28, 2020 16:07
akmadian
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, thanks!
@obulat please ping me here on github if you need another review once you resolve the merge conflicts. |
Ran `npm audit --fix`
Footer 'Donate' button did not fit in a 1/4-sized column on tablet-sized layout, so the the app had a white margin on the right. Making all columns the same size on tablet size fixed this issue. Navbar menu burger button also had a gray background which was set to white.
@akmadian Ari, I've added some more changes to fix layout and build the site. Could you check and merge, if everything is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #174 by @obulat
Description
Updated the CSS of the modal to make it appear correctly.
Tests
All failing tests were updated.
Screenshots
Checklist
Update index.md
).master
branch of the repository.visible errors.
Developer Certificate of Origin
Developer Certificate of Origin