Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modals #175

Merged
merged 8 commits into from
Jun 13, 2020
Merged

Fix modals #175

merged 8 commits into from
Jun 13, 2020

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 28, 2020

Fixes

Fixes #174 by @obulat

Description

Updated the CSS of the modal to make it appear correctly.

Tests

All failing tests were updated.

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested review from a team, brenoferreira and akmadian and removed request for a team May 28, 2020 16:07
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, thanks!

@akmadian
Copy link
Member

@obulat please ping me here on github if you need another review once you resolve the merge conflicts.

Ran `npm audit --fix`
@obulat obulat requested a review from a team June 10, 2020 22:31
Footer 'Donate' button did not fit in a 1/4-sized column on tablet-sized layout, so the the app had a white margin on the right. Making all columns the same size on tablet size fixed this issue. Navbar menu burger button also had a gray background which was set to white.
@obulat
Copy link
Contributor Author

obulat commented Jun 11, 2020

@akmadian Ari, I've added some more changes to fix layout and build the site. Could you check and merge, if everything is OK.

@obulat obulat merged commit e0d79d6 into master Jun 13, 2020
@obulat obulat deleted the modal-fix branch July 31, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modals are broken
2 participants