-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 35 - Write Unit Tests and e2e for HelpSection component #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- Could you please move the
TEST.md
file into./test/
- Please move
HelpSection.spec.js
into./test/unit/specs/components/
Thanks!
I'll fix those right away! |
@akmadian should I also move e2e tests to |
Yes @Joranhezon, please do |
Hi @akmadian sorry for the wait! I got caught up in some university projects, but here it is! I made an e2e test for every link in each pop up of HelpSection, checking if they were redirecting to the correct page. I also updated TEST.md to document a command to run only e2e tests. |
Thanks, @Joranhezon! Merging now :) |
Fixes #35
Description
I've added a snapshot test to check if page's UI is accurate. Also, created some tests to check modals's active attributes before and after the click on it's respective button. Additionally, I created a TEST.MD file to document useful tips and common errors that I found while setting up my environment. Still need to add e2e tests.
Checklist:
Update index.md
).master
branch of the repository.visible errors.
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.