Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 35 - Write Unit Tests and e2e for HelpSection component #43

Merged
merged 10 commits into from
Oct 16, 2019

Conversation

Joranhezon
Copy link

@Joranhezon Joranhezon commented Oct 2, 2019

Fixes #35

Description
I've added a snapshot test to check if page's UI is accurate. Also, created some tests to check modals's active attributes before and after the click on it's respective button. Additionally, I created a TEST.MD file to document useful tips and common errors that I found while setting up my environment. Still need to add e2e tests.

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@Joranhezon Joranhezon changed the title Issue 35 Fix - Write Unit Tests for HelpSection component WIP: Issue 35 Fix - Write Unit Tests for HelpSection component Oct 3, 2019
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Could you please move the TEST.md file into ./test/
  2. Please move HelpSection.spec.js into ./test/unit/specs/components/

Thanks!

@Joranhezon
Copy link
Author

I'll fix those right away!

@akmadian akmadian dismissed their stale review October 3, 2019 22:25

Changes made!

@Joranhezon
Copy link
Author

@akmadian should I also move e2e tests to ./test/e2e/specs/components/ ?

@akmadian
Copy link
Member

akmadian commented Oct 5, 2019

Yes @Joranhezon, please do

@Joranhezon Joranhezon changed the title WIP: Issue 35 Fix - Write Unit Tests for HelpSection component Issue 35 - Write Unit Tests and e2e for HelpSection component Oct 15, 2019
@Joranhezon
Copy link
Author

Joranhezon commented Oct 15, 2019

Hi @akmadian sorry for the wait! I got caught up in some university projects, but here it is! I made an e2e test for every link in each pop up of HelpSection, checking if they were redirecting to the correct page. I also updated TEST.md to document a command to run only e2e tests.

src/components/HelpSection.vue Outdated Show resolved Hide resolved
src/components/HelpSection.vue Outdated Show resolved Hide resolved
src/components/HelpSection.vue Outdated Show resolved Hide resolved
src/components/HelpSection.vue Outdated Show resolved Hide resolved
src/components/HelpSection.vue Outdated Show resolved Hide resolved
src/components/HelpSection.vue Outdated Show resolved Hide resolved
src/components/HelpSection.vue Outdated Show resolved Hide resolved
test/TEST.md Outdated Show resolved Hide resolved
test/e2e/specs/components/HelpSection.js Show resolved Hide resolved
@akmadian
Copy link
Member

Thanks, @Joranhezon! Merging now :)

@akmadian akmadian merged commit cbf54c8 into creativecommons:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for HelpSection component
2 participants