Adding functionalities needed for most organization #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is filter exist and get task id by built in formatter
|
sounds cool, I'll give it a looksie. |
|
|
You are using |
…od to avoid undefined variable exception
|
Hi, sorry just check that after I refactored the methods for handling the call from print_project.php I forget to pass the $project variable to printProject method as parameter. Weirdly, it works well in my production environment with PHP 8.0.22. I already make the fix in my fork by passing $project variabel and tested the functionality again in my production environment and it work just as well as before. So where should we go from here? |
|
It works fine now. I can assure you though, it do not work before the edit on: And very doubtful it worked on yours as it was. That's a hard impossible, the variable simply was not passed, it's not going to make it up. Possible you had made the edit on your server and just didn't commit it? I don't know. Doesn't matter though, it's fine now. |
|
Ah, my bad then. Hope it going well forward. Thx you for responding and accepting my pull request. Cheers 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm currently using this wonderful plugin and applied some adjustment to make life easier for teams/organizations who want to flexibly reporting their tasks.
Check it out if this is suitable for an addition, otherwise I will just keep it at my fork.