Case insensitive tool and agent names #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomdmoura
previously approved these changes
Jan 14, 2024
|
Do you mind fixing conflicts, so we can merge it? |
|
I tried resolving the conflicts but decided to pull these change into the new version myself as it felt simpler, it will be live int he next version so clsogin this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great toolset.
Had tried it with a locally running Mistral 7b and found that this LLM, while being very usable on commodity HW, doesn't always get case and leading/trailing spaces right. With this change the trip planner example started to work.
This PR adds
strip().casefold()for agent names andcasefold()for tool names (asstrip()was existing already)