-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add plugins #34
Conversation
I do realize that this is a very simple and somewhat naive way of doing this, since you could potentially install anything you want. So a check on the packages with regex, checking a pattern like Update I added a check of the plugins' names with regex. |
Attempt of checking plugin name with regex
Fix issue with if statement
Fix regex issue
Change to sh regex
Add regex check of plugin names
Looks extremely good! Thanks so much for your contribution! I will test this myself and then merge it. |
@creyD Thank you! And you are welcome. Out of curiosity - how do you test Actions locally? I've been having a workflow where I make a change, push to a branch, release a new version, and then test it in a separate project. This is extremely cumbersome😂 I can only imagine there is a better way of doing this? |
I am not an expert at this, but here is my process: I test the commands locally (without the yml parameters ...) and then I create a test GitHub repo where I write |
Your new release I tested in this: https://github.com/creyD/prettier_test , will delete this later. |
Ahh I see. I was looking for a way of doing something like: Well, anyways, thanks! |
No need for the infotexture fork now that the upstream action repo has added support for Prettier plugins: - creyD/prettier_action#22 - creyD/prettier_action#34 - creyD/prettier_action#36 Signed-off-by: Roger Sheen <roger@infotexture.net>
This will allow users to specify a list of plugins to add before running prettier on their files. I have used this on Volcano more specifically here
Closes #22