Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.29] OCPBUGS-46027: Cherry-pick changes from containers/storage project #8830

Open
wants to merge 1 commit into
base: release-1.29
Choose a base branch
from

Conversation

kwilczynski
Copy link
Member

@kwilczynski kwilczynski commented Dec 10, 2024

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from containers/storage project.

These changes carry fixes that need to be backported to CRI-O.

Related:

Note

This cherry-pick brings the following Pull Request as a dependency:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@kwilczynski kwilczynski requested a review from mrunalp as a code owner December 10, 2024 07:01
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Dec 10, 2024
@kwilczynski kwilczynski changed the title Cherry-pick changes from multiple containers/* projects [release-1.29] Cherry-pick changes from multiple containers/* projects Dec 10, 2024
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@kwilczynski kwilczynski changed the title [release-1.29] Cherry-pick changes from multiple containers/* projects [WIP] [release-1.29] Cherry-pick changes from multiple containers/* projects Dec 10, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
@kwilczynski kwilczynski force-pushed the feature/backport-updates-to-release-1.29 branch from 34718c1 to 43e49f5 Compare December 10, 2024 08:45
@kwilczynski kwilczynski changed the title [WIP] [release-1.29] Cherry-pick changes from multiple containers/* projects [WIP] [release-1.29] Cherry-pick changes from containers/storage project Dec 10, 2024
@kwilczynski
Copy link
Member Author

/cc @cri-o/cri-o-maintainers
/cc @giuseppe

@openshift-ci openshift-ci bot requested review from giuseppe and a team December 12, 2024 08:57
@kwilczynski kwilczynski changed the title [WIP] [release-1.29] Cherry-pick changes from containers/storage project [release-1.29] Cherry-pick changes from containers/storage project Dec 12, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@kwilczynski
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
Cherry-pick the following changes:

  - containers/storage/pull#2156
  - containers/storage/pull#2162
  - containers/storage/pull#2185

This cherry-pick brings the following Pull Request as a dependency:

  - containers/storage/pull#1833

Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski kwilczynski force-pushed the feature/backport-updates-to-release-1.29 branch from 43e49f5 to 6cc477b Compare December 12, 2024 09:20
@kwilczynski kwilczynski changed the title [release-1.29] Cherry-pick changes from containers/storage project [release-1.29] OCPBUGS-46027: Cherry-pick changes from containers/storage project Dec 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 12, 2024
@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-46027, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-46027 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/assign kwilczynski

What this PR does / why we need it:

Manually cherry-pick changes from containers/storage project.

These changes carry fixes that need to be backported to CRI-O.

Related:

[!NOTE]
This cherry-pick brings the following Pull Request as a dependency:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 12, 2024
@kwilczynski
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@kwilczynski: This pull request references Jira Issue OCPBUGS-46027, which is invalid:

  • expected Jira Issue OCPBUGS-46027 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants