maintainers: promote Sohan and Krzysztof to approvers #8857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
openshift-ci
bot
added
kind/other
haircommander
force-pushed
the
promote-s-kw
branch
from
45f6f67 to
4a37d2f
Compare
|
/hold for a bit to gain consensus |
openshift-ci
bot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8857 +/- ##
=======================================
Coverage 46.95% 46.95%
=======================================
Files 154 154
Lines 21978 21978
=======================================
Hits 10320 10320
Misses 10599 10599
Partials 1059 1059 |
kwilczynski
reviewed
Dec 16, 2024
Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
promote-s-kw
branch
from
4a37d2f to
986b386
Compare
saschagrunert
approved these changes
Dec 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?