Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: secure_getenv symbol not found #1408

Closed
michalbiesek opened this issue Mar 29, 2023 · 1 comment · Fixed by #1410
Closed

[Bug]: secure_getenv symbol not found #1408

michalbiesek opened this issue Mar 29, 2023 · 1 comment · Fixed by #1410
Assignees
@michalbiesek
Labels
bug Something isn't working
Milestone
1.3.2

Comments

@michalbiesek
Copy link
Contributor

michalbiesek commented Mar 29, 2023 •
edited
Loading

Steps To Reproduce

In case:
scope run ls in Alpine < 3.11 we fail with following error:

Error relocating /scope/0/libscope.so: secure_getenv: symbol not found

The reason for that is lack of support secure_getenv in musl library before 1.1.24

The potential solution is to replace usage of secure_getenv in with getenv in AppScope code
@michalbiesek michalbiesek added the bug Something isn't working label Mar 29, 2023
@michalbiesek michalbiesek self-assigned this Mar 29, 2023
@michalbiesek
Copy link
Contributor Author

QA Instructions:

docker run -it --rm --name alpine3 alpine:3.7 ash
### copy scope to container
### docker cp ./bin/linux/x86_64/scope alpine3:scope
./scope run ls
### You should be able to run scope successfully
### Without Error `relocating libscope.so: secure_getenv: symbol not found`

michalbiesek added a commit that referenced this issue Mar 29, 2023
@michalbiesek
(#1408) Remove secure_getenv usage in openssl
368ca3d 
- `secure_get_env` is not supported by musl version prior 1.1.24
Fixes #1408
@michalbiesek michalbiesek linked a pull request Mar 29, 2023 that will close this issue
Remove secure_getenv usage in openssl (1408) #1410
Merged
@michalbiesek michalbiesek added this to the 1.3.2 milestone Mar 29, 2023
@iapaddler iapaddler moved this to In Review in AppScope 1.3.2 Apr 3, 2023
michalbiesek added a commit that referenced this issue Apr 5, 2023
@michalbiesek
(#1408) Add internal (scope) wrapper to secure_getenv
e5eda4c 
- this will remove usage of `secure_getenv` in contrib code
- `secure_get_env` is not supported by musl version prior 1.1.24

Fixes #1408
jrcheli added a commit that referenced this issue Apr 6, 2023
@jrcheli
(#1408) Consolidate similar unit tests for forbidden symbols.
055c966
@iapaddler iapaddler moved this from In Review to Done in AppScope 1.3.2 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalbiesek michalbiesek

Labels
bug Something isn't working
Projects
No open projects
AppScope 1.3.2
Status: Done
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

Remove secure_getenv usage in openssl (1408) criblio/appscope
1 participant
@michalbiesek