Auto mount in Docker containers (#1416) #1440

iapaddler · 2023-04-18T20:59:00Z

Enable procs to load the library in containers
Access the Edge socket if applicable

close #1416
close #1424

… hard-coded values exist.

…e the preload file, not mount.

…Still a WIP.

iapaddler · 2023-04-18T21:00:25Z

Test with scope service
Resolve symbol resolution of runtime/internal/syscall.Syscall6.abi0
Test on x86_64 (ARM64 only thus far)
patch libscope before creating ld.so.preload
Integ tests

src/wrap_go.c

src/utils.c

src/wrap_go.c

…, to a symbol name.

src/wrap_go.c

…on needs to be moved to the new filter command.

src/utils.c

…pdates to config.json.

…kend.

[WIP] OCI Json manipulation

src/wrap_go.c

seanvaleo · 2023-06-14T15:56:16Z

src/utils.c


+#define SYSPRINT_CONSOLE 1


change to 0

seanvaleo · 2023-06-14T16:06:17Z

src/wrap_go.c

+                        //             __FUNCTION__, __LINE__, &data[j]);
+
+                        switch (data[j]) {
+                            // Go 18 and 20


iapaddler added 5 commits April 11, 2023 16:50

Initial support. Scope all processes in a docker container. Debug and…

fe0076f

… hard-coded values exist.

Use the defined libdir. Create intermediate dirs before a mount. Writ…

9aebf88

…e the preload file, not mount.

Resolve an issue where subsequent docker run commands did not mount. …

d3828c5

…Still a WIP.

Mount the Edge socket from within a container.

e5bc522

Merge branch 'release/1.4' into feature/dockerd-mount-1416

f62f9a9

iapaddler added enhancement New feature or request libscope labels Apr 18, 2023

michalbiesek reviewed Apr 19, 2023

View reviewed changes

iapaddler added 3 commits April 19, 2023 16:22

Support the case where some Go execs add the interface version, .abi0…

c836ad9

…, to a symbol name.

Applied review comments.

8262c12

Use the internal libc for mount.

84f58ef

michalbiesek reviewed Apr 25, 2023

View reviewed changes

src/wrap_go.c Outdated Show resolved Hide resolved

src/wrap_go.c Outdated Show resolved Hide resolved

src/wrap_go.c Outdated Show resolved Hide resolved

seanvaleo changed the title ~~Auto mount in Docker containers (1416)~~ Auto mount in Docker containers (#1416) May 2, 2023

iapaddler added 5 commits May 8, 2023 09:43

Merge branch 'release/1.4' into feature/dockerd-mount-1416

fd8f445

Resolved an issue with a unit test.

365ab72

Minor updates intended for clarity.

add7847

WIP: startAutoMount() works, debug needs to be removed and the functi…

20a69f1

…on needs to be moved to the new filter command.

WIP: Auto mount from libscope.

2b62807

michalbiesek reviewed May 16, 2023

View reviewed changes

src/utils.c Outdated Show resolved Hide resolved

src/utils.c Outdated Show resolved Hide resolved

src/utils.c Outdated Show resolved Hide resolved

src/utils.c Outdated Show resolved Hide resolved

src/utils.c Outdated Show resolved Hide resolved

iapaddler and others added 10 commits May 23, 2023 18:02

Added interposition of forkExec in wrap_go.c. Prepping for applying u…

da43893

…pdates to config.json.

Unit test enablement.

46625f4

Add arm64 asm changes

ff6faff

Add OCI test

36b4f58

Add OCI rewrite

59203f3

Testing with alternate pclntab location.

eff5287

Tested locating .gopclntab sections in Go 12, 16 & 20.

cacc545

Located the embedded pclntab and update container config from OCI bac…

3779fba

…kend.

Merge pull request #1498 from criblio/feat-oci-json-manipulation

b131cd9

[WIP] OCI Json manipulation

Merged OCI config. Remove auto mount code from libscope and loader.

0366e69

iapaddler added 3 commits June 7, 2023 19:23

Merge with relkease/1.4

aebfe69

Resolved conflicts in start.go

9f975a4

Removed mount from redfine list and a tap entry for forkExec.

c4f730b

iapaddler marked this pull request as ready for review June 7, 2023 21:13

michalbiesek reviewed Jun 7, 2023

View reviewed changes

src/wrap_go.c Show resolved Hide resolved

src/wrap_go.c Outdated Show resolved Hide resolved

src/wrap_go.c Outdated Show resolved Hide resolved

src/wrap_go.c Outdated Show resolved Hide resolved

michalbiesek reviewed Jun 8, 2023

View reviewed changes

src/wrap_go.c Show resolved Hide resolved

Fixed a copy/pasta error getting symbols from pclntab in Go 16/17.

f4f5628

michalbiesek reviewed Jun 12, 2023

View reviewed changes

src/wrap_go.c Show resolved Hide resolved

src/wrap_go.c Outdated Show resolved Hide resolved

iapaddler added 2 commits June 14, 2023 08:00

Missed a free.

ad7ce02

Merged with release/1.4

79e9881

seanvaleo reviewed Jun 14, 2023

View reviewed changes

src/utils.c Outdated

#define SYSPRINT_CONSOLE 1

Copy link

Collaborator

seanvaleo Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to 0

seanvaleo reviewed Jun 14, 2023

View reviewed changes

src/wrap_go.c Outdated

// __FUNCTION__, __LINE__, &data[j]);

switch (data[j]) {

// Go 18 and 20

Copy link

Collaborator

seanvaleo Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18-20

Remove console debug enable and a comment clarfication.

6c77ea9

seanvaleo merged commit 6370fb8 into release/1.4 Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto mount in Docker containers (#1416) #1440

Auto mount in Docker containers (#1416) #1440

iapaddler commented Apr 18, 2023

iapaddler commented Apr 18, 2023 •

edited

Loading

seanvaleo Jun 14, 2023

seanvaleo Jun 14, 2023

Auto mount in Docker containers (#1416) #1440

Auto mount in Docker containers (#1416) #1440

Conversation

iapaddler commented Apr 18, 2023

iapaddler commented Apr 18, 2023 • edited Loading

seanvaleo Jun 14, 2023

Choose a reason for hiding this comment

seanvaleo Jun 14, 2023

Choose a reason for hiding this comment

iapaddler commented Apr 18, 2023 •

edited

Loading