Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Type Aliases for DoubleWidth Digests #28

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Add Type Aliases for DoubleWidth Digests #28

merged 5 commits into from
Feb 4, 2022

Conversation

crichez
Copy link
Owner

@crichez crichez commented Feb 4, 2022 •
edited
Loading

Objectives

This pull request hopes to clarify and clean up code that uses nested DoubleWidth types, and close #27. The following type aliases were added:

  • Digest128
  • Digest256
  • Digest512
  • Digest1024

Tasks

  • Replace references to DoubleWidth
  • Update documentation to warn clients about performance drawbacks of large digests
  • Ensure all existing tests still pass

@crichez crichez added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 4, 2022
@crichez crichez self-assigned this Feb 4, 2022
@crichez crichez merged commit eacd002 into main Feb 4, 2022
@crichez crichez deleted the doublewidth-type-aliases branch February 4, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crichez crichez

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Type Aliases for DoubleWidth Digests
1 participant
@crichez