Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token to publish-pypi job, fix yaml version error #19

Merged
merged 2 commits into from
May 8, 2024

Conversation

rbavery
Copy link
Collaborator

@rbavery rbavery commented May 7, 2024

Description

this adds the pypi token to the publish step and wraps the python version used to build the wheel in quotes

Related Issue

#13

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make codestyle;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@rbavery rbavery requested a review from fmigneault May 7, 2024 23:55
@@ -24,9 +24,8 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2.2.2
with:
python-version: 3.10
python-version: "3.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@fmigneault fmigneault merged commit ef1ee6e into main May 8, 2024
8 checks passed
@fmigneault fmigneault deleted the debug-publish-pypi branch May 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants