add missing item_assets check + remove mlm:name unique requirement #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
item_assets
definition under a Collection to ensure compatibility withthe Item Assets extension, as mentioned this specification.
Removed
mlm:name
requirement to be unique. There is no way to guarantee this from a single Item's definitionand their JSON schema validation. For uniqueness requirement, users should instead rely on the
id
propertyof the Item, which is ensured to be unique under the corresponding Collection, since it would not be retrievable
otherwise (i.e.:
collections/{collectionID}/items/{itemID}
).Related Issue
n/a
Type of Change
Checklist
CONTRIBUTING.md
guide;make codestyle
;Google
format for all the methods and classes that I used.