Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add devtool utilities #28

Merged
merged 18 commits into from
Nov 10, 2023
Merged

add devtool utilities #28

merged 18 commits into from
Nov 10, 2023

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Nov 8, 2023 •
edited
Loading

Changes

  • Add LICENSE file.
  • Add bump-my-version with make version and make VERSION=<...> bump utilities to self-update release versions.
  • Add more metadata to pyproject.toml.
  • Adjust README.md with updated references and release version indicators.
  • Add CHANGES.md to record version updates.
  • Add dev dependencies to pyproject.toml for testing the package (install with pip install ".[dev]").
  • Remove requirements.txt in favor of all dependencies combined in pyproject.toml.
  • Add test to validate STAC Collection and Item contain source with expected THREDDS format.
  • Fix broken tests and invalid imports.

dchandan
dchandan approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@dchandan dchandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding these!

CHANGES.md Show resolved Hide resolved
@dchandan
Copy link
Collaborator

dchandan commented Nov 9, 2023

Shall we merge this?

@fmigneault
Copy link
Collaborator Author

@dchandan

Shall we merge this?

I'm working on the CI to make sure it runs the test successfully.
Will merge right after it does.

@fmigneault fmigneault requested review from huard and dchandan November 9, 2023 23:37
@fmigneault
Copy link
Collaborator Author

@dchandan @huard
Everything works except python 3.12 that needs xarray-contrib/xncml#57

@fmigneault fmigneault mentioned this pull request Nov 9, 2023
Open
dchandan
dchandan suggested changes Nov 10, 2023
View reviewed changes
STACpopulator/api_requests.py Outdated Show resolved Hide resolved
STACpopulator/populator_base.py Show resolved Hide resolved
STACpopulator/populator_base.py Outdated Show resolved Hide resolved
STACpopulator/populator_base.py Show resolved Hide resolved
tests/data/stac_collection_testdata_xclim_cmip6_catalog.json Outdated Show resolved Hide resolved
@fmigneault fmigneault requested a review from dchandan November 10, 2023 17:48
@fmigneault fmigneault merged commit e309b78 into master Nov 10, 2023
7 checks passed
@fmigneault fmigneault deleted the devtools branch November 10, 2023 19:05
@huard huard mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchandan dchandan dchandan approved these changes

@huard huard Awaiting requested review from huard huard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmigneault @dchandan @huard @fmigneault-crim