Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore pyessv-archive locally since not a git submodule anymore #61

Merged
merged 1 commit into from
Oct 10, 2024
Merged

ignore pyessv-archive locally since not a git submodule anymore #61

merged 1 commit into from
Oct 10, 2024

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Oct 9, 2024 •
edited
Loading

relates to #58

@fmigneault fmigneault requested a review from huard as a code owner October 9, 2024 22:22
mishaschwartz
mishaschwartz approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm surprised that the directory is still there after the update since it was explicitly removed by c291918

Maybe I don't understand the way git acts when you remove a submodule vs a regular directory 🤷

@fmigneault
Copy link
Collaborator Author

@mishaschwartz
Even if removed here, it still exists on my local clone. This ensures I do not add it back by mistake ;)

@fmigneault fmigneault merged commit 280ef69 into master Oct 10, 2024
9 checks passed
@fmigneault fmigneault deleted the ignore-pyessv-archive branch October 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishaschwartz mishaschwartz mishaschwartz approved these changes

@huard huard huard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmigneault @huard @mishaschwartz