add test to validate potential problem when requesting many vault files uploads #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/tests
ahandan
reviewed
May 26, 2022
| """ | ||
| test_data = json.dumps({"data": "test"}, ensure_ascii=False).encode("UTF-8") | ||
| headers = {"Accept": ContentType.APP_JSON} # multi-part content-type added automatically with boundary | ||
| for i in range(30): |
There was a problem hiding this comment.
Est-ce que qu'on veut définir une variable Nombre_de_requête ?
There was a problem hiding this comment.
On pourrait, mais je ne vois pas le besoin pour un test automatisé comme celui-ci.
ahandan
reviewed
May 26, 2022
| # make sure access was not by chance | ||
| resp = self.app.get(url=f"/vault/{file_id}", expect_errors=True) | ||
| assert resp.status_code == 403 | ||
| resp = self.app.get(url=f"/vault/{file_id}", headers={"X-Auth-Vault": token}) |
There was a problem hiding this comment.
Bien que ma machine était fautive, est-ce qu'on veut mettre un temps d'attente entre les deux requêtes ?
There was a problem hiding this comment.
Je pense que ce test (s'il y a problème) devrait lever le plus d'erreurs possible parce que ça s'exécute aussi vite que possible.
Je ne pense pas que l'ajout d'un délai vas changer le résultat.
|
LGTM, à moins qu'on veuille avoir des tests plus larges, celui si est simple et test le vault convenablement selon moi. |
ahandan
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.