-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WeaverClient/CLI with auth handler and other CLI adjustments #442
Conversation
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 81.17% 81.48% +0.31%
==========================================
Files 76 76
Lines 14281 14542 +261
Branches 3109 3158 +49
==========================================
+ Hits 11592 11850 +258
+ Misses 1982 1974 -8
- Partials 707 718 +11
Continue to review full report at Codecov.
|
…her operation examples)
Went through most of it and up until now, everything looks pretty good. Also started testing the CLI directly. So far I like the changes and the inclusion of the Magpie Auth provider. Will continue tomorrow, especially the CLI, relevant documentation and live tests. |
Changes:
CLI
Authentication Handler parameters and correspondingauth
argument of instantiated classes forWeaverClient
methods that allows inline request authentication and authorization resolution to access aprotected service. Any Authentication Handler implementation can be used to fulfill required server functionalities.
CLI
option-t
by-T
(Docker
token) duringdeploy
operation to match naming convention ofother options (resolves Support authentication using CLI and WeaverClient #400).
CLI
option-H
bynH
(--no-headers
) andwH
(--with-headers
) to respectivelyenable or (explicitly) disable return of headers from response of the executed operation.
CLI
option-L
bynL
(--no-links
) andwL
(--with-links
) to respectivelyenable (explicitly) or disable return of links from response of the executed operation.
-H
option by new-H/--header
argument allowing insertion of explicitly providedrequest headers for relevant requests called by the executed operation.
Fixes:
CLI
operations assuming valid JSON response to instead return error response content and status code.CLI
rendering of various optional arguments and groups when displaying help messages.References
Resolves DAC-460