Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cookie header to WPS WorkerRequest to ensure auth propagation through workflow steps #661

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

fmigneault
Copy link
Collaborator

No description provided.

@fmigneault fmigneault added the project/OGC-OSPD Related to OGC Open Science Persistent Demonstrator. label Jun 5, 2024
@fmigneault fmigneault self-assigned this Jun 5, 2024
@github-actions github-actions bot added ci/doc Issue related to documentation of the package feature/CWL Issue related to CWL support labels Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (325aa4f) to head (2a8d187).
Report is 116 commits behind head on master.

Files with missing lines Patch % Lines
weaver/processes/wps_process_base.py 44.44% 4 Missing and 1 partial ⚠️
weaver/wps/service.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   85.75%   85.74%   -0.01%     
==========================================
  Files          79       79              
  Lines       18859    18862       +3     
  Branches     2912     2912              
==========================================
+ Hits        16173    16174       +1     
- Misses       1929     1931       +2     
  Partials      757      757              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmigneault fmigneault merged commit 79b7abc into master Jun 5, 2024
45 of 47 checks passed
@fmigneault fmigneault deleted the workflow-step-auth branch June 5, 2024 06:22
fmigneault added a commit to bird-house/birdhouse-deploy that referenced this pull request Jun 5, 2024
## Overview
Weaver: Adjust invalid `data_sources.yml` definitions.


## Changes

**Non-breaking changes**
- Weaver: Adjust invalid `data_sources.yml` definitions.

  - Add the missing `data_sources.yml` volume mount for  `weaver-worker`.
  - When `weaver-worker` runs a `Workflow`, the nested `step` process locations need to be resolved according to the
    current `"localhost"` instance. However, the Web API running in `weaver` service is not visible from the worker.
    Since the configuration is shared between `weaver` and `weaver-worker`, use the public endpoint of `weaver` to
    make process URL resolution consistent, and also provide more useful references in job logs when resolution fails.

**Breaking changes**
- n/a

## Related Issue / Discussion

- identified while working on crim-ca/weaver#661

## Additional Information

- https://pavics-weaver.readthedocs.io/en/latest/processes.html#data-source

## CI

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package feature/CWL Issue related to CWL support project/OGC-OSPD Related to OGC Open Science Persistent Demonstrator.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant