-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing cwl metadata #702
Parsing cwl metadata #702
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 85.94% 85.95% +0.01%
==========================================
Files 80 80
Lines 19551 19578 +27
Branches 3045 3055 +10
==========================================
+ Hits 16803 16829 +26
Misses 1983 1983
- Partials 765 766 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting a PR.
Make sure that you have added tests to validates new features or bugfixes. Also, ensure that existing test suites are still working with the change using the commit test statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add an entry to CHANGES.md
(same items as the PR description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just editorial edits left.
CHANGES.rst
Outdated
(fixes `#463 <https://github.com/crim-ca/weaver/issues/463>`_) | ||
- Add more metadata mapping details in documentation (fixes `#613 <https://github.com/crim-ca/weaver/issues/613>`_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the trailing .
instead of the space, for each item.
docs/source/package.rst
Outdated
Additional compatible elements found under ``metadata`` in :term:`WPS` Context | ||
|
||
Parameters in :term:`CWL` Context: | ||
|
||
- ``s:author`` | ||
- ``s:citation`` | ||
- ``s:codeRepository`` | ||
- ``s:contributor`` | ||
- ``s:dateCreated`` | ||
- ``s:license`` | ||
- ``s:releaseNotes`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this, I believe it should be added directly to the metadata
line that is already present in the table. Basically, just extend the right side (where $schemas
/$namespace
is indicated) with the mention of those fields.
You can also add the [#cwl_schemaorg]_
footnote reference (as in the s:keywords
case), that points to the CWL metadata example below, which contains all of those fields.
docs/source/package.rst
Outdated
@@ -1312,6 +1312,20 @@ Below is a list of compatible elements. | |||
+-----------------------------------------+----------------------------------------------------------+ | |||
| ``abstract``/``description`` | ``doc`` | | |||
+-----------------------------------------+----------------------------------------------------------+ | |||
| ``version`` | ``s:version``/``s:softwareVersion`` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also use the [#cwl_schemaorg]_
.
@Nazim-crim Thanks! |
Changes
Add parsing of additional metadata from schema.org in CWL document to convert into process fields
fixes Parse additional metadata from schema.org in CWL document to convert into process fields #463
fixes Add more metadata mapping details in documentation #613