fix(Twitter): fix Custom translator patch

crimera · Jan 28, 2025 · 8065fa3 · 8065fa3
1 parent 72a72f2
commit 8065fa3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/src/main/kotlin/crimera/patches/twitter/misc/shareMenu/hooks/ShareMenuButtonInitHook.kt b/src/main/kotlin/crimera/patches/twitter/misc/shareMenu/hooks/ShareMenuButtonInitHook.kt
@@ -10,7 +10,6 @@ import com.android.tools.smali.dexlib2.Opcode
 import com.android.tools.smali.dexlib2.builder.instruction.BuilderInstruction35c
 import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction
 import com.android.tools.smali.dexlib2.iface.instruction.ReferenceInstruction
-import com.android.tools.smali.dexlib2.iface.reference.Reference
 import crimera.patches.twitter.misc.settings.SettingsPatch
 
 object ShareMenuButtonInitHook : MethodFingerprint(
@@ -48,7 +47,7 @@ object ShareMenuButtonInitHook : MethodFingerprint(
     }
 
     fun setButtonIcon(
-        buttonReference: Reference,
+        buttonReference: String,
         iconStr: String,
         offset: Int = 0,
     ) {
@@ -58,7 +57,7 @@ object ShareMenuButtonInitHook : MethodFingerprint(
         val instructions = method.getInstructions()
         instructions.filter { it.opcode == Opcode.SGET_OBJECT }.forEach { instruction ->
             val ref = (instruction as ReferenceInstruction).reference.toString()
-            if (ref == buttonReference.toString()) {
+            if (ref.contains(buttonReference)) {
                 var index = instruction.location.index + offset
                 index =
                     method

diff --git a/...n/kotlin/crimera/patches/twitter/misc/shareMenu/nativeDownloader/NativeDownloaderPatch.kt b/...n/kotlin/crimera/patches/twitter/misc/shareMenu/nativeDownloader/NativeDownloaderPatch.kt
@@ -87,13 +87,14 @@ object NativeDownloaderPatch : BytecodePatch(
         method.removeInstruction(filters.location.index - 1)
 
         // show icon always
-        ShareMenuButtonAddHook.addButton("SendToTweetViewSandbox", "enableNativeDownloader")
+        var buttonReference = "SendToTweetViewSandbox"
+        ShareMenuButtonAddHook.addButton(buttonReference, "enableNativeDownloader")
 
         // text func
         ShareMenuButtonInitHook.setButtonText("View in Tweet Sandbox", "piko_pref_native_downloader_alert_title")
 
         // icon
-        //   ShareMenuButtonInitHook.setButtonIcon(buttonReference, "ic_vector_incoming")
+        ShareMenuButtonInitHook.setButtonIcon(buttonReference, "ic_vector_incoming")
 
         SettingsStatusLoadFingerprint.enableSettings("nativeDownloader")
         offset = true

diff --git a/...n/kotlin/crimera/patches/twitter/misc/shareMenu/nativeTranslator/NativeTranslatorPatch.kt b/...n/kotlin/crimera/patches/twitter/misc/shareMenu/nativeTranslator/NativeTranslatorPatch.kt
@@ -80,8 +80,9 @@ object NativeTranslatorPatch : BytecodePatch(
             """.trimIndent(),
         )
 
+        var buttonReference = "SendToSpacesSandbox"
         // show icon always
-        ShareMenuButtonAddHook.addButton("SendToSpacesSandbox", "enableNativeTranslator")
+        ShareMenuButtonAddHook.addButton(buttonReference, "enableNativeTranslator")
 
         // text func
         var offset = 0
@@ -91,7 +92,7 @@ object NativeTranslatorPatch : BytecodePatch(
         ShareMenuButtonInitHook.setButtonText("View in Spaces Sandbox", "translate_tweet_show", offset)
 
         // icon
-        //     ShareMenuButtonInitHook.setButtonIcon(buttonReference, "ic_vector_sparkle", 0)
+        ShareMenuButtonInitHook.setButtonIcon(buttonReference, "ic_vector_sparkle", 0)
 
         SettingsStatusLoadFingerprint.enableSettings("nativeTranslator")
     }