Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactoring #48

Draft
wants to merge 19 commits into
base: dev
Choose a base branch
from
Draft

Major refactoring #48

wants to merge 19 commits into from

Conversation

crimist
Copy link
Owner

@crimist crimist commented Mar 24, 2023 •
edited
Loading

  • Pull the global logger out of the config package - it's a terrible hack. Probably going to move it to zap's global logger.
  • Remove global configuration pointer in config package - pass specific required configuration down to other packages.

@crimist
Copy link
Owner Author

crimist commented Mar 30, 2023

Turning this into a major refactor - turns out 17 yr old me had a lot to learn 😬

@crimist crimist changed the title Refactor Config package + Logger Major refactoring Mar 30, 2023
@crimist
Copy link
Owner Author

crimist commented Mar 30, 2023

Can't really break such major internal changes into different PRs / branches, I guess this is v0.2

@crimist crimist changed the base branch from master to dev June 20, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crimist