Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored to classes #1

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Refactored to classes #1

merged 2 commits into from
Nov 16, 2022

Conversation

crismc
Copy link
Owner

@crismc crismc commented Nov 16, 2022

Description

Related Issue

This PR fixes or closes issue: fixes #

  • Limitation on configuration
  • Modular usage of components
  • More readable
  • Just generally... better

Motivation and Context

To make this more configurable, and modular, the entire library has been refactored to use classes
New options for debugging added
Ability to specify the smbus number via the configuration
Why do this... because its better

How Has This Been Tested

Locally tested on fresh installs of RPi3 and 4

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@crismc crismc merged commit 64b42bd into master Nov 16, 2022
@crismc crismc deleted the refactor_to_classes branch November 17, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant