Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark suite for all algorithms #46

Merged
merged 3 commits into from
May 8, 2020

Conversation

storozhukBM
Copy link
Contributor

Benchmark suite for all algorithms.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          12       12           
  Lines         458      458           
=======================================
  Hits          392      392           
  Misses         39       39           
  Partials       27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b3b62...ba5f57c. Read the comment docs.

Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests define algo in slice, some in map. Probably slice will be enough and Signer.Algorithm method can be used as a test name.

@storozhukBM storozhukBM requested a review from cristaloleg May 8, 2020 18:22
}

func runVerifyBench(b *testing.B, builder *jwt.Builder, verifier jwt.Verifier) {
builder.Build(jwt.StandardClaims{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-op?

jwt_bench_test.go Show resolved Hide resolved
@cristaloleg cristaloleg merged commit 1d58f52 into cristalhq:master May 8, 2020
@cristaloleg cristaloleg mentioned this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants