Extract initialization of service in a dedicated service lifecycle manager #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose is to move out the initialization code in the CriteoInternal class or in other classes. For instance, previously, the config update was done within the prefetch method of the BidManager. Hopefully tests caught that removing the prefetch also removed the initial config call. But to ease the development and the maintenance, it is preferable to centralize such initialization in a dedicated manager.
This also remove the config from the BidRequestSender which is used for the deprecated cache bidding.
|
Kudos, SonarCloud Quality Gate passed! |
TurpIF
requested review from
leonardlabat,
afewcc and
Pgb-Criteo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.