-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT]👷 test robustness #230
Draft
CedricGatay
wants to merge
10
commits into
main
Choose a base branch
from
build/testRobustness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101b729
to
fedc3d9
Compare
Split unit tests and functional tests * keep on using `multi_scan` as long as we've not narrow down flaky tests * divided in two `multi_scan` parts and auto-install certificates on simulator (through `xcrun` instead of external gem) * added quick `nc` check before running test to fail early if wiremock is not run Still needs to be tested on github action side
Allow to override dispatch_queue for testing BannerView, main queue might be too occupied for the test to succeed.
Open app store test never succeeds on versions lower than 14, earlier versions are opening browser to app store.
CR_NetworkManagerTest relies on local wiremock server, moved it out of unit test test plan and moved it to functional one.
API_AVAILABLE does not prevent test for running on older iOS version
Allow the UI to "breathe" before marking creative loading expectation as a success, as it often goes too fast with expectations against loading webview phase (executing JS sooner that it should).
Started to split out runs of tests for functional or unit ones.
Use multi-jobs pipeline for release task too.
Split tests to avoid stupid test flakyness due to bad global state / mocking.
40caf47
to
907584a
Compare
Tests are way to flaky to be run without multiscan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fiabilize test chain by :