Add needs_docker_privileged

cross-rs · Apr 7, 2022 · d88eb5e · d88eb5e
1 parent a309bf1
commit d88eb5e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/docker.rs b/src/docker.rs
@@ -168,7 +168,10 @@ pub fn run(
     docker.args(&["-e", "PKG_CONFIG_ALLOW_CROSS=1"]);
 
     docker.arg("--rm");
-    docker.arg("--privileged");
+
+    if target.needs_docker_privileged() {
+        docker.arg("--privileged");
+    }
 
     // We need to specify the user for Docker, but not for Podman.
     if let Ok(ce) = get_container_engine() {

diff --git a/src/main.rs b/src/main.rs
@@ -204,6 +204,14 @@ impl Target {
 
         !native && (self.is_linux() || self.is_windows() || self.is_bare_metal())
     }
+
+    fn needs_docker_privileged(&self) -> bool {
+        let arch_32bit = self.triple().starts_with("arm")
+            || self.triple().starts_with("i586")
+            || self.triple().starts_with("i686");
+
+        arch_32bit && self.is_android()
+    }
 }
 
 impl std::fmt::Display for Target {