Skip to content

Commit

Permalink
Merge #316
Browse files Browse the repository at this point in the history
316: Patch for breaking 32-bit float conversions on ppc (#313). r=reitermarkus a=Alexhuszagh

Use qemu-3.0.1 for all powerpc architectures, and 4.1.0 for everything else.

Note: @reitermarkus, this requires bash for the scripting language, not shell, which the Dockerfiles currently use. I'm not sure if this is a deal-breaker.

Closes #313.

Co-authored-by: Alex Huszagh <ahuszagh@ahuszagh.localdomain>
  • Loading branch information
bors[bot] and Alex Huszagh authored Sep 9, 2019
2 parents a43d540 + 4709ab3 commit fc6d350
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions docker/qemu.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
#!/usr/bin/env bash

set -ex

main() {
local version=4.1.0

# Qemu versions 3.10.0 and above break 32-bit float conversions
# on powerpc, powerpc64, and powerpc64le. Last known working version
# is 3.0.1.
# Upstream Issue:
# https://bugs.launchpad.net/qemu/+bug/1821444
if [[ $1 == ppc* ]]; then
version=3.0.1
fi

local arch=$1 \
os=$2 \
softmmu=$3 \
Expand Down

0 comments on commit fc6d350

Please sign in to comment.