-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glibc compatibility / make x86_64-unknown-linux-gnu
ubuntu again and provide image for glibc compatibility
#680
Comments
x86_64-unknown-linux-gnu
ubuntu again and provide image for glibc compatibility x86_64-unknown-linux-gnu
ubuntu again and provide image for glibc compatibility
This is a problem caused by the way we have an out of date version of Centos as the basis for the container. |
I don't really understand the problem or context or goal here given the issues on this that I've read. Is the goal to make everything Ubuntu based or not? What's the glibc issue that's being talked about here? |
the issue is that some people are still using rhel/centos 7, and we've been kind enough to make it easier for those users to compile with cross without linking in glibc > 2.17, and to do this were using centos 7. |
The reason I personally want all images to be ubuntu is due to #678 |
At O.S. Systems we did a custom image in the lines of Rust toolchain used one which allows even older Glibc (2.12). We could make use of Debian for this and avoid CentOS use. |
I don't think we need to go below 2.17 (RHEL7), but that could work nicely. |
This has now been solved. To opt in to using CentOS, specify in your cross configuration (e.g [target.x86_64-unknown-linux-gnu]
image = "ghcr.io/cross-rs/x86_64-unknown-linux-gnu:main-centos" |
Thanks! it work. I think many people not knowing this only by reading the README.md, |
@fatihaziz feel free to open a pr with those changes! |
1251: Update README.md for centos image target notes [5] and [7] r=Emilgardis a=fatihaziz Based on #680, it is stated to add `ghcr.io/cross-rs/...` before the image tag. However, this is not stated in the README.md file, resulting in the error "docker login" being needed. With this update, the problem is fixed. Co-authored-by: FatihAziz <m.fatihalaziz@gmail.com>
I think it's unexpected all linux images are ubuntu, except
x86_64-unknown-linux-gnu
, I think this can be remedied by building two images:x86_64-unknown-linux-gnu
andx86_64-unknown-linux-gnu.2.17
Thankfully, we have not published the centos change yet, so this can be remedied
Related to the glibc issue, I think we can remedy this by suggesting users use
zig cc
ala cargo-zigbuild. We can even use a similar approach setting*_CC
tozig cc --target x86_64-linux-gnu.2.17
and make it easier for users of thex86_64-unknown-linux-gnu
image to choose a glibcping #591
The text was updated successfully, but these errors were encountered: