Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zig-cc and zigbuild versions. #1330

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update zig-cc and zigbuild versions. #1330

merged 1 commit into from
Sep 12, 2023

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented Sep 12, 2023

No description provided.

@sagudev sagudev requested a review from a team as a code owner September 12, 2023 05:34
@Emilgardis Emilgardis added no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets. labels Sep 12, 2023
@sagudev
Copy link
Contributor Author

sagudev commented Sep 12, 2023

Currently fails with:

   running: "/target/.zig-cache/cargo-zigbuild/0.17.2/zigcxx-i586-unknown-linux-musl.sh" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m32" "-march=pentium" "-Wl,-melf_i386" "-Wall" "-Wextra" "-o" "/target/i586-unknown-linux-musl/debug/build/hellopp-a1a57f003a4c4646/out/hellopp.o" "-c" "hellopp.cc"
  cargo:warning=error: unsupported linker arg: -melf_i386

@Emilgardis
Copy link
Member

bors try --target zig

bors bot added a commit that referenced this pull request Sep 12, 2023
@bors
Try #1330: --target zig
55ca9f3
@sagudev
Copy link
Contributor Author

sagudev commented Sep 12, 2023 •
edited

Given that we already have warnings in current builds this must be rust-cross/cargo-zigbuild#96.

@bors
Copy link
Contributor

bors bot commented Sep 12, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Emilgardis
Emilgardis approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@sagudev
Copy link
Contributor Author

sagudev commented Sep 12, 2023

I do not think that try build works as there was no zig test run.

@bors
Copy link
Contributor

bors bot commented Sep 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 539a2b0 into cross-rs:main Sep 12, 2023
23 of 24 checks passed
@Emilgardis Emilgardis mentioned this pull request Oct 20, 2023
Merged
@Emilgardis Emilgardis added this to the v0.3.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sagudev @Emilgardis