Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why fallback happened when subcommand is not supported, and fix rustdoc #1342

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

Emilgardis
Copy link
Member

Resolves #1341 by adding rustdoc as a supported command. Also adds a explanation when a unsupported subcommand is used.

This also fixes a bug with --list

@Emilgardis Emilgardis requested a review from a team as a code owner October 11, 2023 16:51
@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Oct 11, 2023
@@ -55,7 +55,7 @@ pub fn fmt_subcommands(stdout: &str, msg_info: &mut MessageInfo) -> Result<()> {
}
if !host.is_empty() {
msg_info.print("Host Commands:")?;
for line in &cross {
for line in &host {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! :3

@Emilgardis
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a537585 into main Oct 12, 2023
23 checks passed
@bors bors bot deleted the explain-fallback-fix-rustdoc branch October 12, 2023 19:50
@Emilgardis Emilgardis added this to the v0.3.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when building with cross rustdoc
1 participant