Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade qemu and integrate qemu-user runners for loongarch64 #1466

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Upgrade qemu and integrate qemu-user runners for loongarch64 #1466

merged 1 commit into from
Apr 4, 2024

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Apr 3, 2024 •
edited
Loading

Even though the Debian/LoongArch port is still in progress, qemu-user is now available. This PR upgrades qemu to version 8.2.2 and incorporates qemu-user runners for the loongarch64-unknown-linux-gnu target.

Close #1467

@heiher heiher requested a review from a team as a code owner April 3, 2024 06:51
@Emilgardis
Copy link
Member

Emilgardis commented Apr 3, 2024 •
edited
Loading

/ci try

need to do a try for all targets, this should only fail for x86_64-unknown-dragonfly as we have ci errors for it on the main branch

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@heiher heiher marked this pull request as draft April 3, 2024 08:13
@heiher heiher marked this pull request as ready for review April 3, 2024 12:42
@Emilgardis
Copy link
Member

/ci try

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Try run for comment

Failed Jobs

Successful Jobs

List

Emilgardis
Emilgardis requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This change updates qemu for a lot of the targets, can you edit the commit message and title of the pr to reflect this. Ideally we should also update the readme with correct qemu versions, but that can be done later, it just takes some time to do the inventory

@heiher heiher changed the title Add qemu-user runners for loongarch64-linux-gnu Upgrade qemu and integrate qemu-user runners for loongarch64 Apr 3, 2024
@heiher
Copy link
Contributor Author

heiher commented Apr 3, 2024

LGTM!

This change updates qemu for a lot of the targets, can you edit the commit message and title of the pr to reflect this. Ideally we should also update the readme with correct qemu versions, but that can be done later, it just takes some time to do the inventory

Thanks! Done.

(PS: This PR enables editing by maintainers. Feel free to make direct edits if you have better ideas. 😃

@heiher heiher requested a review from Emilgardis April 4, 2024 05:39
Emilgardis
Emilgardis reviewed Apr 4, 2024
View reviewed changes
.changes/1466.json Outdated Show resolved Hide resolved
@heiher heiher requested a review from Emilgardis April 4, 2024 06:37
@heiher heiher mentioned this pull request Apr 4, 2024
Open
@Emilgardis Emilgardis added the CI-loongarch64-unknown-linux-gnu Run CI for loongarch64-unknown-linux-gnu label Apr 4, 2024
Emilgardis
Emilgardis approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Emilgardis Emilgardis added this pull request to the merge queue Apr 4, 2024
Merged via the queue into cross-rs:main with commit 82a53af Apr 4, 2024
22 checks passed
@heiher heiher deleted the loongarch64-runner-user branch April 4, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
CI-loongarch64-unknown-linux-gnu Run CI for loongarch64-unknown-linux-gnu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade qemu and integrate qemu-user runners for loongarch64-linux-gnu
2 participants
@heiher @Emilgardis