-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allocate a pseudo-TTY #169
Conversation
This fixes issue cross-rs#52 as far as I can tell. Since documentation on the `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross.
Thanks, @pitkley. LGTM. Let's see what homu thinks. @homunkulus r+ |
📌 Commit 974d8c6 has been approved by |
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
💔 Test failed - status-travis |
Sorry that I forgot about this PR. Unfortunately, I can't make anything out of the failed architectures. Are those failures unrelated/flaky, or is this something caused by this PR? |
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
💔 Test failed - status-travis |
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
💔 Test failed - status-travis |
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
💔 Test failed - status-travis |
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
💔 Test failed - status-travis |
Hello. Is there any update on the status of this PR? Thanks! |
Don't allocate a pseudo-TTY This fixes issue #52 as far as I can tell. Since documentation on the Docker `-t` flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross. From my arguably limited tests, I have [confirmed](https://gist.github.com/pitkley/c581f612225688937cc8b7f3a7deff9a) that `echo hello | cross run` works. Furthermore, this enables me to run `cross build` in a Gitlab CI job, which otherwise also failed with the error mentioned in #52: `the input device is not a TTY`.
💔 Test failed - status-travis |
Is it possible to please get this merged? I can't tell from the test output what is causing the failures? |
It would be really nice to run cross in a CI job, is it possible to get this PR merged? |
@homunkulus try |
Thank you @Dylan-DPC - Any insight as to what's happening during the test? |
bors: try |
We lost color output if we don't allocate a tty. See for example https://travis-ci.org/rust-embedded/cross/jobs/440652090#L862 |
tryBuild failed |
This also hit me trying to build using Could this PR be modified to use atty to detect whether it's running on a TTY, and use that to decide whether to pass through |
Any chance this PR could be merged ? It's the only blocking step before being able to use |
bors try |
tryBuild failed |
@rust-embedded/tools Could someone help with this? |
any update on this, this is blocking me from using cross on CI |
I'm also looking into using Azure Pipelines for CI, and it seems like there's several projects that have hacky workarounds that are waiting for this fix, e.g.,
would be great to have these issues resolved.. |
Sorry to generate more noise on this, but what can we do to help this PR get merged? It's not clear to me whether the CI issues are legit? I would also really like to use this with Azure Pipelines. Alternatively does anyone know how to get Azure Pipelines to allocate a TTY for a script? |
bors try |
tryBuild failed |
This fixes issue #52 as far as I can tell.
Since documentation on the Docker
-t
flag is rather sparse, I am not sure if this has any negative implications on existing usage of cross.From my arguably limited tests, I have confirmed that
echo hello | cross run
works. Furthermore, this enables me to runcross build
in a Gitlab CI job, which otherwise also failed with the error mentioned in #52:the input device is not a TTY
.