Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hard-coding NEON support for armv7-unknown-linux-musleabihf. #255

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Stop hard-coding NEON support for armv7-unknown-linux-musleabihf. #255

merged 1 commit into from
Aug 25, 2019

Conversation

briansmith
Copy link
Contributor

Fixes #252.

Signed-off-by: Brian Smith brian@briansmith.org

Fixes #252.

Signed-off-by: Brian Smith <brian@briansmith.org>
@briansmith
Copy link
Contributor Author

Note: I didn't test this on a device or emulator without NEON support.

@jamesmunns
Copy link
Contributor

bors try

Thanks @briansmith!

bors bot added a commit that referenced this pull request Jan 26, 2019
@briansmith
Copy link
Contributor Author

We should consider whether we need to make any changes like what was done in https://github.com/rust-lang/rust/pull/56725/files along with this. Thoughts?

@bors
Copy link
Contributor

bors bot commented Jan 26, 2019

try

Build failed

@Dylan-DPC-zz
Copy link

bors: try

bors bot added a commit that referenced this pull request Feb 2, 2019
@bors
Copy link
Contributor

bors bot commented Feb 2, 2019

try

Build failed

@Disasm Disasm added T-tools S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. labels Feb 26, 2019
This was referenced Feb 26, 2019
@reitermarkus
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 25, 2019
255: Stop hard-coding NEON support for armv7-unknown-linux-musleabihf. r=reitermarkus a=briansmith

Fixes #252.

Signed-off-by: Brian Smith <brian@briansmith.org>

Co-authored-by: Brian Smith <brian@briansmith.org>
@reitermarkus reitermarkus removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. label Aug 25, 2019
@bors
Copy link
Contributor

bors bot commented Aug 25, 2019

Build succeeded

@bors bors bot merged commit 1232d0e into cross-rs:master Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

armv7-unknown-linux-musleabihf/armv7-linux-musleabihf hard-coded NEON support
5 participants