Allow specifying volumes in Cross.toml.
#443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan-DPC-zz
approved these changes
Jul 4, 2020
|
Build succeeded: |
| @@ -152,10 +170,10 @@ pub fn run(target: &Target, | |||
| .args(&["-v", &format!("{}:/cargo:Z", cargo_dir.display())]) | |||
| // Prevent `bin` from being mounted inside the Docker container. | |||
| .args(&["-v", "/cargo/bin"]) | |||
| .args(&["-v", &format!("{}:/project:Z", mount_root.display())]) | |||
| .args(&["-v", &format!("{}:/{}:Z", mount_root.display(), mount_root.display())]) | |||
There was a problem hiding this comment.
This change will make it impossible to use a rustc wrapper with Cargo, which is the only way to pass custom flags due to #463, and the wrapper path needs to be absolute.
Setting it to /project/my-wrapper.sh works just fine, but if the mount point is changed, there is no easy way to pass the absolute path to the wrapper.
There was a problem hiding this comment.
Hmm, actually I already have to do something different for cross builds vs. native builds, so maybe this won't be that big of a deal? It's certainly a breaking change though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.