more environment configuration #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6912f8a needs to be merged, as it fixes a wrong assumption |
Emilgardis
commented
Apr 6, 2022
| } | ||
|
|
||
| impl CrossToml { | ||
| /// Parses the [`CrossToml`] from a string | ||
| pub fn from_str(toml_str: &str) -> Result<Self> { | ||
| let cfg: CrossToml = toml::from_str(toml_str)?; | ||
| Ok(cfg) | ||
| Ok(dbg!(cfg)) |
Emilgardis
changed the title
|
opened #683 for the fix |
Emilgardis
commented
Jun 2, 2022
| @@ -185,6 +185,18 @@ impl Config { | |||
| Ok(collected) | |||
| } | |||
|
|
|||
|
|
|||
| pub fn env_variables(&self, target: &Target) -> HashMap<String, String> { | |||
| // Does not support env variable config, that would make not much sense | |||
There was a problem hiding this comment.
#742 (comment) and #743
There was a problem hiding this comment.
this could be removed, replaced with #748
Alexhuszagh
added
enhancement
A-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.