Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cargo workspace and path dependencies to work seamlessly #684

Merged
merged 5 commits into from
Jun 7, 2022

Commits on Jun 3, 2022

  1. Configuration menu
    Copy the full SHA
    0eecee1 View commit details
    Browse the repository at this point in the history
  2. feat: Parse Cargo's --manifest-path option to determine mounted docker

    root
    
    This commits adds support for parsing the `--manifest-path` option to cross. So
    far, the `Cargo.toml` manifest of the crate (or its Cargo workspace) to compile
    has been assumed to be in the current working directory. This means, that
    relative crate dependencies were not supported, because those paths were not
    mapped into the docker container.
    
    Take the following example structure, where `my-bin` depends on `my-lib`:
    .
    ├── my-bin
    │   ├── Cargo.toml
    │   └── src
    │       └── main.rs
    └── my-lib
        ├── Cargo.toml
        └── src
            └── lib.rs
    
    This commits enables such scenarios, by running cross from `.` like so:
    `cross build --manifest-path=my-lib/Cargo.toml --target x86_64-pc-windows-gnu`,
    as `.` is mapped as the container's root, and the options passed through to
    Cargo.
    
    Related cross-rs#388 cross-rs#139 cross-rs#277 cross-rs#78
    
    Co-authored-by: Kviring Alexey <alex@kviring.com>
    2 people authored and Emilgardis committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    09e5d0e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4232a2a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Update workspace tests

    Ensure we build the entire workspace using the `--workspace` flag both with and without the manifest path, and also ensure we build the binary with all our workspace dependencies.
    Alexhuszagh authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    12b4727 View commit details
    Browse the repository at this point in the history
  2. Fix unbounded variable error on Bash 3.2

    `"${@}"` is an unbound variable on Bash 3.2, while `"$@"` is not, and Bash 3.2 is the pre-installed version on macOS.
    Alexhuszagh authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3e59d85 View commit details
    Browse the repository at this point in the history