Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump freebsd ssl #690

Merged
merged 2 commits into from
Apr 22, 2022
Merged

bump freebsd ssl #690

merged 2 commits into from
Apr 22, 2022

Conversation

Emilgardis
Copy link
Member

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner April 10, 2022 14:35
@Emilgardis
Copy link
Member Author

Why do we need this again?

@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Apr 10, 2022
@Emilgardis
Copy link
Member Author

bors try --target freebsd

bors bot added a commit that referenced this pull request Apr 10, 2022
@bors
Try #690: --target freebsd
37c4483
@bors
Copy link
Contributor

bors bot commented Apr 10, 2022

try

Build failed:

@Emilgardis @Jules-Bertholet
update sqlite version
f2c3a68 
Co-authored-by: Jules Bertholet <jules.bertholet@gmail.com>
@Emilgardis
Copy link
Member Author

@reitermarkus do you know why we add sqlite and openssl to freebsd? Seems contradictory, since we opted to not include openssl in other targets

@Emilgardis
Copy link
Member Author

bors try --target freebsd

bors bot added a commit that referenced this pull request Apr 10, 2022
@bors
Try #690: --target freebsd
cf2603c
@bors
Copy link
Contributor

bors bot commented Apr 10, 2022

try

Build succeeded:

@Emilgardis Emilgardis mentioned this pull request Apr 19, 2022
Merged
@Emilgardis
Copy link
Member Author

@cross-rs/maintainers anyone able to r+ this?

@Emilgardis
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 19, 2022
@bors
Try #690:
db50efa
@bors
Copy link
Contributor

bors bot commented Apr 19, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member Author

ping @cross-rs/maintainers :)

svenstaro
svenstaro approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, it builds :)

@svenstaro
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 22, 2022

Build succeeded:

@bors bors bot merged commit 3a5210c into cross-rs:main Apr 22, 2022
@Emilgardis Emilgardis deleted the freessl-n branch April 22, 2022 16:53
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jules-Bertholet Jules-Bertholet Jules-Bertholet left review comments

@svenstaro svenstaro svenstaro approved these changes

Assignees
No one assigned
Labels
no changelog A valid PR without changelog (no-changelog)
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Emilgardis @svenstaro @Jules-Bertholet