Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sysroot to BINDGEN_EXTRA_CLANG_ARGS env var #707

Merged
merged 2 commits into from
May 8, 2022
Merged

Add sysroot to BINDGEN_EXTRA_CLANG_ARGS env var #707

merged 2 commits into from
May 8, 2022

Conversation

Jules-Bertholet
Copy link
Contributor

This allows projects using rust-bindgen to build properly.

@Jules-Bertholet Jules-Bertholet requested a review from a team as a code owner May 8, 2022 05:52
@Jules-Bertholet Jules-Bertholet changed the title Add sysroot to BINDGEN_EXTRA_CLANG_ARGSenv var Add sysroot to BINDGEN_EXTRA_CLANG_ARGS env var May 8, 2022
Emilgardis
Emilgardis approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented May 8, 2022

Build succeeded:

@bors bors bot merged commit f046673 into cross-rs:main May 8, 2022
@Jules-Bertholet Jules-Bertholet deleted the bindgen-sysroot branch May 8, 2022 16:06
Jules-Bertholet added a commit to Jules-Bertholet/cross that referenced this pull request May 8, 2022
@Jules-Bertholet
Fix BINDGEN_EXTRA_CLANG_ARGS
5334650 
They are supposed to be lowercase 😳
It seems I didn't test cross-rs#707 as well as I thought…
@Jules-Bertholet Jules-Bertholet mentioned this pull request May 8, 2022
Merged
bors bot added a commit that referenced this pull request May 8, 2022
@bors @Jules-Bertholet
Merge #708
c8cb80b 
708: Fix `BINDGEN_EXTRA_CLANG_ARGS` r=Emilgardis a=Jules-Bertholet

They are supposed to be lowercase 😳
It seems I didn't test #707 as well as I thought…

Co-authored-by: Jules Bertholet <jules.bertholet@gmail.com>
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Emilgardis Emilgardis mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
container-images enhancement
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Jules-Bertholet @Emilgardis @Alexhuszagh