Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FreeBSD builds more resilient. #730

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

Alexhuszagh
Copy link
Contributor

Do not hardcode exact versions of the FreeBSD release, openssl, or sqlite3 versions. Rather, use the FreeBSD ftp server to determine the latest 12.X release, and use the package list downloaded to determine the latest openssl and sqlite3 versions.

Since we use a dynamic version of FreeBSD, and have no good way of detecting this later, we write the version and revision to /opt/freebsd-version.

Fixes #695.

@Alexhuszagh Alexhuszagh requested a review from a team as a code owner May 30, 2022 17:33
Do not hardcode exact versions of the FreeBSD release, `openssl`, or `sqlite3` versions. Rather, use the FreeBSD ftp server to determine the latest `12.X` release, and use the package list downloaded to determine the latest `openssl` and `sqlite3` versions.

Since we use a dynamic version of FreeBSD, and have no good way of detecting this later, we write the version and revision to `/opt/freebsd-version`.

Fixes cross-rs#695.
@Alexhuszagh
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 30, 2022
@bors
Copy link
Contributor

bors bot commented May 30, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member

Great! One sad thing though, because we cache from the previous images, this won't invalidate often. We should look into that separately.

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented May 30, 2022

Build succeeded:

@bors bors bot merged commit 7caf557 into cross-rs:main May 30, 2022
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added container-images A-bsd Area: BSD-family targets labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bsd Area: BSD-family targets container-images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FreeBSD builds more resiliant
2 participants