Fix ARMv6 HF image to correctly build for ARMv6 architecture. #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
force-pushed
the
crosstool
branch
2 times, most recently
from
2b0fb4b
to
8da6a58
Compare
|
bors try |
Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7. This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`. Closes cross-rs#426.
tryBuild succeeded: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 31, 2022
734: Fix ARMv6 HF image to correctly build for ARMv6 architecture. r=Emilgardis a=Alexhuszagh Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7. This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`. Closes #426. 735: add issue templates r=Emilgardis a=Emilgardis resolves #732 Co-authored-by: Alex Huszagh <ahuszagh@gmail.com> Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
|
bors cancel |
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 31, 2022
734: Fix ARMv6 HF image to correctly build for ARMv6 architecture. r=Emilgardis a=Alexhuszagh Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7. This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`. Closes #426. 735: add issue templates r=Emilgardis a=Emilgardis resolves #732 Co-authored-by: Alex Huszagh <ahuszagh@gmail.com> Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
bors cancel bors r+ |
|
Canceled. |
|
Build succeeded: |
11 tasks
11 tasks
|
I think adding a custom docker image in cross.toml is not read when using this target. Could it be this PR that introduced this problem? |
|
@talksik I'm not sure I follow your comment, there should not be any issues with using a custom docker image according to the wiki page and this PR doesn't touch any logic related to that. Could you open a new issue or reach out on our matrix server (found in the readme) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
arm-unknown-linux-gnueabihfto build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7.This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running
crosstool-ng/configure.sh, which scans that directory for all*.config.infiles, and configures them todocker/crosstool-config. The script can have the toolchain versions modified viaGCC_VERSION,GLIBC_VERSION, andLINUX_VERSION.Closes #426.