-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ARMv6 HF image to correctly build for ARMv6 architecture. #734
Conversation
2b0fb4b
to
8da6a58
Compare
bors try |
Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7. This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`. Closes cross-rs#426.
tryBuild succeeded: |
bors r+ |
734: Fix ARMv6 HF image to correctly build for ARMv6 architecture. r=Emilgardis a=Alexhuszagh Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7. This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`. Closes #426. 735: add issue templates r=Emilgardis a=Emilgardis resolves #732 Co-authored-by: Alex Huszagh <ahuszagh@gmail.com> Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
bors cancel |
Canceled. |
bors r+ |
734: Fix ARMv6 HF image to correctly build for ARMv6 architecture. r=Emilgardis a=Alexhuszagh Change the `arm-unknown-linux-gnueabihf` to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7. This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running `crosstool-ng/configure.sh`, which scans that directory for all `*.config.in` files, and configures them to `docker/crosstool-config`. The script can have the toolchain versions modified via `GCC_VERSION`, `GLIBC_VERSION`, and `LINUX_VERSION`. Closes #426. 735: add issue templates r=Emilgardis a=Emilgardis resolves #732 Co-authored-by: Alex Huszagh <ahuszagh@gmail.com> Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
This PR was included in a batch that was canceled, it will be automatically retried |
bors cancel bors r+ |
Canceled. |
Build succeeded: |
I think adding a custom docker image in cross.toml is not read when using this target. Could it be this PR that introduced this problem? |
@talksik I'm not sure I follow your comment, there should not be any issues with using a custom docker image according to the wiki page and this PR doesn't touch any logic related to that. Could you open a new issue or reach out on our matrix server (found in the readme) Thanks! |
Change the
arm-unknown-linux-gnueabihf
to build a toolchain using crosstool-ng, so that we build a toolchain using ARMv6 support, rather than ARMv7.This also adds support for crosstool-ng-based images, which are configured from template config files so that we can modify the GCC, glibc, and Linux versions. These are configured by running
crosstool-ng/configure.sh
, which scans that directory for all*.config.in
files, and configures them todocker/crosstool-config
. The script can have the toolchain versions modified viaGCC_VERSION
,GLIBC_VERSION
, andLINUX_VERSION
.Closes #426.