Fix docker_read_mount_paths to support podman.
#792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
force-pushed
the
docker_in_docker
branch
from
aa40461
to
02256b6
Compare
Emilgardis
reviewed
Jun 14, 2022
| let mount_finder = if docker_in_docker { | ||
| MountFinder::new(docker_read_mount_paths()?) | ||
| MountFinder::new(docker_read_mount_paths(&engine)?) |
Used to hard-code a search for docker, which is now removed to use the path of the located engine. Also adds the `CROSS_CONTAINER_IN_CONTAINER` environment variables, which overrides the `CROSS_DOCKER_IN_DOCKER` variable.
Alexhuszagh
force-pushed
the
docker_in_docker
branch
from
02256b6
to
c59aa93
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to hard-code a search for docker, which is now removed to use the path of the located engine. Also adds the
CROSS_CONTAINER_IN_CONTAINERenvironment variables, which overrides theCROSS_DOCKER_IN_DOCKERvariable.