-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement baking #849
implement baking #849
Conversation
with this comes a question, should we tag all these even if they will eventually come up in a manifest? Reason for including this is to enable easier cleanup, as right now the images that are in the manifest will be untagged. I think it's fine to tag them, I'm just not sure how to tag them. Maybe https://github.com/Emilgardis/cross/pkgs/container/s390x-unknown-linux-gnu/versions reason for tagging would be to show what digest corresponds to what version, and which one is the most "newest" one. |
The proposed workflow for a multi platform image would be
|
} else { | ||
docker_bake.args(&["--set", "*.output=type=registry"]); | ||
} | ||
//docker_bake.args(&["--set", "*.cache-to=type=inline"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be commented
this also enables appending to a manifest, which would enable doing sequential or even separate builds of images to the same manifest
marking as draft again, this is ready for use though, there is something I'm not liking about the naming though. The issue is that for proper/good caching, we need unique tags for each architecture, otherwise the cache will use the most "upper" image in the manifest. I think
|
closing this, the code has diverged to much and I want to reimplement this. The idea would be to append |
No description provided.